Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to not includedeleting KDS from package.json #393

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Update documentation to not includedeleting KDS from package.json #393

merged 1 commit into from
Jan 3, 2023

Conversation

marcellamaki
Copy link
Member

Description

Removes the step that instructs devs to delete the package.json reference to KDS when using yarn link

Issue addressed

Resolves a problem discussed in Slack where several team members had trouble with yarn link working correctly when deleting this from package.json.

@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Dec 6, 2022
@marcellamaki marcellamaki requested a review from rtibbles December 6, 2022 18:02
nucleogenesis
nucleogenesis approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thank you!

@marcellamaki marcellamaki merged commit 9d2a946 into learningequality:develop Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

@rtibbles rtibbles Awaiting requested review from rtibbles

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcellamaki @nucleogenesis