Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Update kdropdown menu api #346" follow-up #361

Merged
merged 6 commits into from
Sep 15, 2022
Merged

"Update kdropdown menu api #346" follow-up #361

merged 6 commits into from
Sep 15, 2022

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Sep 15, 2022 •
edited
Loading

Description

#346 follow-up. It contains a bug fix and some changelog and documentation updates, please see commit messages.

Steps to test

Do the changelog and documentation updates make sense?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change has been added to the changelog

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Post-merge updates and tracking

  • Learning Platform update PR is submitted
  • Learning Platform update PR is merged
  • Studio update PR is submitted
  • Studio update PR is merged
  • Data Portal update PR is submitted
  • Data Portal update PR is merged

Comments

@MisRob
Add more information about recent updates to the changelog
05a3e43 
and clean up documentation (keep information about recent
changes in the changelog rather than in docs + couple minor
updates)

Follow-up to
learningequality#346
@MisRob
Cleanup obsolete code and documentation string
8049d2f 
default slot is not alternative to `text` anymore

Follow-up to
learningequality#346
@MisRob
Remove obsolete condition
ac42443 
Follow-up to
learningequality#346

Fixes 'Property or method "disabled" is not defined
on the instance but referenced during render.'
@MisRob
Make 'hasDropdown' prop oficially public
b23d1a2 
Follow-up to learningequality#346
where we removed KButton from KDropdownMenu. As a result,
products now need to wrap KDropdownMenu in KButton and therefore
need to use 'hasDropdown' property for dropdown menus that are
within buttons. This commit exposes this prop in documentation.
@MisRob
Update changelog
1c21e44
@MisRob
Fix changelog links
5356fa3
@MisRob MisRob changed the title Kdropdown updates "Update kdropdown menu api #346" follow-up Sep 15, 2022
@MisRob MisRob requested a review from marcellamaki September 15, 2022 12:44
@MisRob MisRob marked this pull request as ready for review September 15, 2022 12:44
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 15, 2022
@MisRob MisRob mentioned this pull request Sep 15, 2022
Merged
9 tasks
marcellamaki
marcellamaki approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you for doing this follow up, @MisRob!

@marcellamaki marcellamaki merged commit 185f5ff into learningequality:develop Sep 15, 2022
@MisRob MisRob deleted the kdropdown-updates branch October 14, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MisRob @marcellamaki