KCheckbox: Wrap default's slot content in <label> #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
MisRob
force-pushed
the
kcheckbox-fix-label
branch
7 times, most recently
from
c1257aa to
f7cd8be
Compare
no matter of whether `label` prop or the default slot is used to provide the label content.
MisRob
force-pushed
the
kcheckbox-fix-label
branch
2 times, most recently
from
e49b417 to
e57168e
Compare
+ smaller phrasing updates
MisRob
force-pushed
the
kcheckbox-fix-label
branch
from
e57168e to
4353c09
Compare
|
@radinamatic I will appreciate your review You can test checkboxes used on the preview of the updated KDS documentation page here https://deploy-preview-351--kolibri-design-system.netlify.app/kcheckbox/ and also in Kolibri in this PR learningequality/kolibri#9648 |
radinamatic
approved these changes
Aug 25, 2022
1 task
MisRob
added a commit
to MisRob/kolibri
that referenced
this pull request
Aug 29, 2022
The only user-facing update between the previous and the new version is learningequality/kolibri-design-system#351 Updates to Kolibri related to that PR have been addressed in 414c1ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<div>, making the checkbox inaccessible when label's content is provided via the default slot. This PR fixes it by replacing<div>with<label>(this also makes using the default slot consistent with using thelabelproperty)KCheckboxdocumentation page and adds some examples of how to use labelsIssue addressed
Addresses #347
Before/after screenshots
KCheckboxdocumentationSteps to test
KCheckboxesused in examples (visually + markup)Testing checklist
changelogReviewer guidance
Post-merge updates and tracking