Add tests for KModal
#320
Merged
Add tests for KModal
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
approved these changes
Mar 4, 2022
| }, | ||
| listeners: { cancel: onClick }, | ||
| }); | ||
| expect(wrapper.findComponent({ name: 'KButton' }).props().text).toEqual(cancelText); |
There was a problem hiding this comment.
Never again will I import the component now that I know I can pass an object with the name property!
There was a problem hiding this comment.
YES! I learned that, I think, from reading someone else's test, and 🤯 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KModalchangelog.mdIssue addressed
Fixes #305
Steps to test
yarn run testin the terminal(optional) Implementation notes
Does this introduce any tech-debt items?
No
Testing checklist
changelogReviewer guidance
Post-merge updates and tracking
Comments