Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite/environment to KDS #309

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Conversation

sairina
Copy link
Contributor

@sairina sairina commented Feb 2, 2022

Description

  • Configures Jest to run in KDS
  • Sets up a GitHub Action to run tests on push/PR

Issue addressed

None

Steps to test

  1. Run jest in terminal. There are already existing tests. Command: yarn test
  2. All tests should pass (2 should be skipped, currently).

(optional) Implementation notes

Does this introduce any tech-debt items?

  • When node gets updated in Kolibri, we will need to update this
  • We may want to require frontend tests to pass in order to merge into main in the future

Testing checklist

  • Contributor has fully tested the PR manually
  • The change has been added to the changelog

Reviewer guidance

  • Is the code clean and well-commented?

Post-merge updates and tracking

  • Learning Platform update PR is submitted
  • Learning Platform update PR is merged
  • Studio update PR is submitted
  • Studio update PR is merged
  • Data Portal update PR is submitted
  • Data Portal update PR is merged

Comments

@sairina sairina requested a review from nucleogenesis February 2, 2022 22:03
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nucleogenesis nucleogenesis merged commit a1f3964 into learningequality:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants