New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable loaders page #272

Merged

indirectlylit merged 1 commit into learningequality:main from indirectlylit:loaders

Oct 28, 2021

Contributor

indirectlylit commented Oct 28, 2021 •

edited

Loading

Description

Enabled 'loading' page which was written but missing

Before/after screenshots

before	after

Steps to test

check /loaders URL

Testing checklist

Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical and brittle code paths are covered by unit tests
The change has been added to the changelog

Reviewer guidance

Is the code clean and well-commented?
Are there tests for this change?
Are all UI components LTR and RTL compliant (if applicable)?
Add other things to check for here

Post-merge updates and tracking

Learning Platform update PR is submitted
Learning Platform update PR is merged
Studio update PR is submitted
Studio update PR is merged
Data Portal update PR is submitted
Data Portal update PR is merged

Comments

indirectlylit requested a review from jtamiace

October 28, 2021 19:39

Contributor Author

indirectlylit commented Oct 28, 2021

@jtamiace mind taking a quick look at this previously-hidden design guidance on loaders?


          enable loaders page

a2d09d2

indirectlylit force-pushed the loaders branch from f408b99 to a2d09d2 Compare

October 28, 2021 19:42

indirectlylit merged commit 09d6b27 into learningequality:main

indirectlylit deleted the loaders branch

October 28, 2021 23:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet