Fix textbox autofocus triggering invalid message #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test failures in a Studio PR indicated a regression in
KTextbox
. Looking at the code, I surmised the issue resulted from usingautofocus
along with how the invalid state is triggered.Before/after screenshots
Steps to test
core-js
dependency to KDS(optional) Implementation notes
At a high level, how did you implement this?
If
autofocus
is enabled, skip first focus event before assigningchangedOrFocused
, which influences the computed propertyshowInvalidMessage
Testing checklist
changelog
Reviewer guidance
Post-merge updates and tracking
Comments