Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional icons for docs #231

Merged
merged 3 commits into from
May 11, 2021

Conversation

radinamatic
Copy link
Member

@radinamatic radinamatic commented May 8, 2021

Description

After working on updating Kolibri docs, 3 more icon substitutions were found as missing: ❌ for incorrect answers in reports, yellow key for superadmin user, and ✔️ outlined for registered facility (used only once in Kolibri, but with the upcoming KDP docs, it might be needed more).

Before/after screenshots

Before After
Selection_018 Selection_020

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@radinamatic radinamatic added category: docs content Design patterns and component usage WIP labels May 8, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nucleogenesis nucleogenesis merged commit d98a9db into learningequality:v0.2.x May 11, 2021
@radinamatic radinamatic removed the WIP label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs content Design patterns and component usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants