Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'warningIncomplete' and rename 'publishedResource' to 'unpublishedResource' #229

Conversation

radinamatic
Copy link
Member

Description

Follow-up to #217. Adds the warningIncomplete icon substitution needed for Studio docs, and renames the publishedResource to unpublishedResource. My bad for not having noticed the inconsistent name during the #217 PR review.

Before/after screenshots

Selection_009

Does this introduce any tech-debt items?

Not that I'm aware of...

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@radinamatic radinamatic requested a review from nucleogenesis May 6, 2021 05:51
@radinamatic radinamatic added this to the Documentation milestone May 6, 2021
@radinamatic radinamatic added the category: docs content Design patterns and component usage label May 6, 2021
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nucleogenesis nucleogenesis merged commit 354a0a3 into learningequality:v0.2.x May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs content Design patterns and component usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants