KCheckbox description prop, simplified logic around slot vs label showing #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Fixes #35
I also thought that the
v-if-else
block there was weird because if I gave both a slot and a label it would show neither - so I picked one to be the override.Now if you give a slot and a label you'll see what is passed to the slot - if you don't give a slot it's expected you give a label.
Before/after screenshots
Steps to test
yarn link kolibri-design-system
in yourkolibri
local repokolibri-design-system
repoKCheckbox
in the code and find it in the app itselfdescription
prop with a value.At a high level, how did you implement this?
Added the prop and updated the template to display it properly - basically stole the whole thing from
KRadioButton
.Does this introduce any tech-debt items?
Nope.
Reviewer guidance
Comments