Code

Kdropdown keyboard navigation#185

Code

Merged

rtibbles merged 14 commits intolearningequality:mainlearningequality/kolibri-design-system:mainfrom marcellamaki:kdropdown-keyboard-navigationmarcellamaki/kolibri-design-system:kdropdown-keyboard-navigationCopy head branch name to clipboardMay 24, 2022

+137-23

Commits

Commits on May 12, 2022

• Add keyboard navigation to dropdown menu

  marcellamaki

  committed
  0841da6

• re-add commented out code, and remove unnecessary containFocus prop

  marcellamaki

  committed
  481189c

• update code to use arrow keys for menu navigation

  marcellamaki

  committed
  8b015f4

• fix linting

  marcellamaki

  committed
  321a649

• Fix tab navigation in popover. Tabbing does not move between menu options, but rather advances to next element in tab order

  marcellamaki

  committed
  4d794ce

• Add keyboard modality support for UiMenuOption and so works

  marcellamaki

  committed
  2361a84

• fix linting

  marcellamaki

  committed
  07ca4ef

• Revert some changes to trackInputModality, but add new options to better manage keyboard event focus by default on interactive elements, while allowing explicit support for keyboard navigation

  marcellamaki

  committed
  e4b530a

• Manage 'clicks' separately based on mouseup vs. keyboard presses

  marcellamaki

  committed
  65fe3a8

Commits on May 18, 2022

• Revert test changes; update git: reference to https: in yarn.lock

  marcellamaki

  committed
  f60af80

Commits on May 20, 2022

• Switch to event.key reference, using .keyCode as fallback only

  marcellamaki

  committed
  2ee8772

• Ensure both JS state and the body attribute are set for keyboard modality

  marcellamaki

  committed
  8dc1b3d

• Resolve feedback

  marcellamaki

  committed
  8cdef91

Commits on May 24, 2022

• Remove console

  marcellamaki

  committed
  fcb8cb0