New pattern: page headers #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khangmach
approved these changes
Jan 11, 2021
|
I meant to link to the button page and forgot. Will get to that |
There was a problem hiding this comment.
This looks good.
I think it could use a bit more coordination with the App Bar page which has some overlapping concepts (back-arrow navigation and page titles, specifically)
some examples of possible coordination:
- compare/contrast use cases
- consistent and divergent terminology as appropriate
- cross-links or even consolidation
…ge titles and app bar titles
|
@indirectlylit Does this seem accurate and help clarify the overlap between the app bar guidelines and page headers?
|
|
Never mind, I had forgotten to commit the second image |
|
LGTM this is awesome! Unless @indirectlylit has outstanding concerns this should be good to merge |
|
great, thanks for addressing my feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eyes on the truncation spec in particular would be helpful
Google doc reference https://docs.google.com/document/d/1oVVFXCOooUd_fI8Tr8YZsrL5acrDTmIBjU8kgZPkViw/edit#