move material icons from normal to dev dependency and update readme #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make KDS 30 MB smaller for Kolibri and Studio
|
Actually, some of the other dependencies also look like dev. For example:
|
|
The others ought to be good added to |
|
thanks @nucleogenesis - moved those dependencies also. Ready for review & merge |
indirectlylit
force-pushed
the
icon-dependency
branch
from
f8f5ab7 to
aea1ed8
Compare
indirectlylit
force-pushed
the
icon-dependency
branch
from
aea1ed8 to
58dcd93
Compare
indirectlylit
changed the title
nucleogenesis
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make KDS 30 MB smaller for users, e.g. Kolibri, Studio, KDP
ref: https://learningequality.slack.com/archives/CTG8XDTCL/p1607447862001200
cc @nucleogenesis @jonboiser