-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding glossary to design system #134
Conversation
Thank you for pushing on this! I'll have to go back and check my notes from a few years ago, before we made a first glossary, I remember for some reason not being happiest with the TBX. |
I believe TBX is the only format Crowdin offers downloads in |
I think that the table's two left-most columns look squished. This may be a more of a critique of the design system layout itself though - perhaps a max-width of 900 or so might look better (the grid layout of the columns could then be adjusted so at least the left-most column has more breathing room). I'd be curious to see how that might affect other parts of the app's appearance though. It's not a big deal honestly just looked off to me a bit. A couple thoughts:
|
Okay - hopefully the API supports it also. I had these functions written for import/export, but it could also be done as a manual UI process
quite easy
When we first created it, we discussed updating it once per translation push on Kolibri (once per major release) |
@nucleogenesis added filter and widened overall table and left column: |
@radinamatic @nucleogenesis we should decide what the process for managing the glossary "source of truth" should be. See the discussion in this PR to refresh your memory about work and stop-gap decisions made previously: |
da92c01
to
33c65ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@indirectlylit @radinamatic this PR looks good to me - but I think we should merge this and discuss that process in a quick meeting or on Slack. |
Adds glossary based on Crowdin tbx file to design system