Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app bar documentation #108
Add app bar documentation #108
Changes from 2 commits
c1eaa0b
1210ffb
ce42aac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have specifications on when to use black color vs purple? Or is this something we're looking to deprecate? It looks like there's a spec for the content renderer without its black app bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided during documentation phase that black is just for pages with editing functionality (single-task pages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be helpful to specify when we should and shouldn't use a bottom bar, and also what type of metadata is and isn't allowed here. I remember you mentioned there's specific kind of metadata that would go on the left side of the bottom bar vs the metadata that would appear right next to the submit/cancel buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided that further bottom bar specifications would be housed in the single task page pattern doc (on the way). This is why I generalized it here as "contextual information". See more here: https://docs.google.com/document/d/1wQa3MitsbjLnF4_POvXO6v2X-dGKru52RmIkOZHzkko/edit#heading=h.og8271ldbw4c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can a few layout pointers in the layout section. But as for "when to use", they should only be used on single task pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tracked as an issue? I know this is what we want to move towards, but we should make sure it describes the current, or soon to be, state of things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a tracked issue once I finalize all the documentation related to it. Will comment out in the meantime