Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCard: Complete vertical/horizontal layouts with no thumbnail #699

Closed
MisRob opened this issue Jul 26, 2024 · 3 comments
Closed

KCard: Complete vertical/horizontal layouts with no thumbnail #699

MisRob opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
category: library Shared code library Component: KCard P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Jul 26, 2024

Summary

This is one of the follow-ups to #625

Check that KCard supports vertical/horizontal layouts with no thumbnail well and add some examples to the documentation page.

This is to ensure that it can support cards like

Screenshot from 2024-07-26 21-30-16

Guidance

  • Try if cards like above can be easily achieved by the current KCard or if we need to add some internal code or new interface APIs to be able to do so
  • I think there's no need to distinguish between 'vertical' and 'horizontal' layout in this case when 'thumbnailDisplay' is 'none'. So the expected behavior would be that any time thumbnailDisplay='none', KCard's output would be such as illustrated on the designs.

References

Figma

@MisRob MisRob added P2 - normal Priority: Nice to have category: library Shared code library Component: KCard labels Jul 26, 2024
@MisRob
Copy link
Member Author

MisRob commented Jul 31, 2024

With @AllanOXDi we agreed to use the same approach for hiding the slot areas when empty as in #702. That is, by adding preserverFooter and preserveBelowTitle props.

@marcellamaki marcellamaki added this to the KCard 2.0 and KCardGrid milestone Aug 13, 2024
@MisRob
Copy link
Member Author

MisRob commented Aug 22, 2024

Note that here we will preserve 24px spaces introduced here #704 (slightly different from the screenshot)

@AllanOXDi
Copy link
Member

fix in #699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library Component: KCard P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants