Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken "develop" branch link #479

Closed
BabyElias opened this issue Oct 25, 2023 · 6 comments
Closed

Broken "develop" branch link #479

BabyElias opened this issue Oct 25, 2023 · 6 comments
Assignees

Comments

@BabyElias
Copy link
Contributor

Current behavior

The "develop" branch no longer exists on the kolibri-design-system repository, while it is mentioned in the Readme.md file and also, has a broken link addressing the same on https://develop--kolibri-design-system.netlify.app/
image
image

Desired behavior

References of the branch should be removed in case the branch no longer exists Or new link should be provided if the branch exists.

@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

Ah yes, I made some changes to branches, and didn't realize these places need to be updated. Thanks for reporting!

This section in the README
Screenshot from 2023-10-26 06-04-53

needs to say "...from the main branch at https://main--kolibri-design-system.netlify.app/"

@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

and also, has a broken link addressing the same on https://develop--kolibri-design-system.netlify.app/

This will be fixed by the above update in the README since we won't visit develop-- build anymore. I assume it will stay live though because I believe Netlify keeps all previous builds alive. That's not a problem.

@BabyElias
Copy link
Contributor Author

Okayy, working on this change.
Thank you for the insights :)

@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

Ah okay, that's great, thanks! I will assign you then.

BabyElias added a commit to BabyElias/kolibri-design-system that referenced this issue Oct 26, 2023
@BabyElias
Copy link
Contributor Author

Created PR #482 for the issue :)

@MisRob
Copy link
Member

MisRob commented Oct 31, 2023

Closed by #482

@MisRob MisRob closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants