Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapping rather than Text Truncation on KRadioButton #350

Closed
marcellamaki opened this issue Aug 16, 2022 · 4 comments
Closed

Use wrapping rather than Text Truncation on KRadioButton #350

marcellamaki opened this issue Aug 16, 2022 · 4 comments

Comments

@marcellamaki
Copy link
Member

Product

Kolibri, potentially Studio?

Desired behavior

Rather than using text truncation on radio buttons (encountered/needed mainly on small screens, wrap the text so that all text is displayed)

Current behavior

Currently, the text truncates with an ellipsis

(Optional) The Value Add

This will prevent the potential loss of important information to users on smaller screens (especially if the radio button is a phrase or sentence, rather than one or two words, like a yes/no choice)

(Optional) Possible Tradeoffs

There might be scenarios where the truncation would make more sense? So far, we have not encountered any definitive scenarios, however.

@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Aug 16, 2022
@marcellamaki
Copy link
Member Author

This can be a starter issue for our new colleagues, but should be done with support for proper context about KDS. The task itself is quite manageable, but navigating the relationship between working in develop on KDS and Kolibri, testing, etc. should be done with guidance/support.

@MisRob
Copy link
Member

MisRob commented Aug 16, 2022

As suggested in the related issues, labels in general (=> text truncation or wrapping etc. as well) wouldn't ideally be controlled so tightly by KDS - we could pass anything as a label from products (perhaps, we could keep some truncation logic for the sake of simplicity, but in that case, it should be optional and easily overridable)

@marcellamaki
Copy link
Member Author

Closed in #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants