Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit KRadioButton Text Truncation #302

Closed
marcellamaki opened this issue Jan 31, 2022 · 2 comments
Closed

Revisit KRadioButton Text Truncation #302

marcellamaki opened this issue Jan 31, 2022 · 2 comments
Labels
TODO: needs decisions Further discussion and planning necessary

Comments

@marcellamaki
Copy link
Member

Product

Kolibri
Reported by Radina here:
learningequality/kolibri#8808
learningequality/kolibri#8949
and in several other issues through 0.15 Kolibri testing

In some situations, it may make sense to have the text truncate, but in other places, wrapping might make more sense. i.e. network address truncation, vs. a long phrase vs. a long word (i.e. frequently in German)

i.e.
image

@nucleogenesis
Copy link
Member

Noting that the truncation was added here learningequality/kolibri#6830 - I personally think that the wrapping text I screenshotted during testing makes more sense in general. I don't see the value in eliding part of the radio button's label.

@marcellamaki
Copy link
Member Author

I've opened a follow up issue for the actual change, and will close this out as the decision has been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs decisions Further discussion and planning necessary
Projects
None yet
Development

No branches or pull requests

2 participants