update changelog

learningequality · Sep 3, 2024 · e5203ca · e5203ca
1 parent 35b6402
commit e5203ca
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 151 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,148 +4,16 @@ Changelog is rather internal in nature. See release notes for the public overvie
 
 ## Upcoming version 5.x.x (`develop` branch)
 
-<!-- [DO NOT REMOVE-USED BY GH ACTION] PASTE CHANGELOG -->
-
-
-- [#765]
-  - **Description:** Fixes update changelog workflow to avoid expecting a comment after the invisible comment `<!-- [DO NOT REMOVE-USED BY GH ACTION] CHANGELOG START -->`.
-  - **Products impact:** none.
-  - **Addresses:** -
-  - **Components:** -
-  - **Breaking:** -
-  - **Impacts a11y:** -
-  - **Guidance:** -
-
-[#765]: https://github.com/learningequality/kolibri-design-system/pull/765
-
-
-- [#762]
-  - **Description:**  Updates dropshadows to the latest design guidelines
-  - **Products impact:**  Visual
-  - **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/724
-  - **Components:** All components with dropshadows
-  - **Breaking:**  no
-  - **Impacts a11y:**  no
-  - **Guidance:** -
-
-[#762]: https://github.com/learningequality/kolibri-design-system/pull/762
-
-- [#722]
-  - **Description:** Inserts the overlay container element `#k-overlay` to an application's document body during KDS initialization.
-  - **Products impact:** KDS initialization
-  - **Addresses:** -
-  - **Components:** -
-  - **Breaking:** no
-  - **Impacts a11y:** no
-  - **Guidance:** Remove any custom teleportation logic and use new KDS components and props instead.
-
-[#722]: https://github.com/learningequality/kolibri-design-system/pull/722
-
-- [#722]
-  - **Description:** Adds new `KOverlay` component
-  - **Products impact:** New API
-  - **Addresses:** -
-  - **Components:**  `KOverlay`
-  - **Breaking:** no
-  - **Impacts a11y:** no
-  - **Guidance:** -
-
-[#722]: https://github.com/learningequality/kolibri-design-system/pull/722
-
-- [#722]
-  - **Description:** Renames `KModal`'s `appendToRoot` prop to `appendToOverlay`
-  - **Products impact:** Updated API
-  - **Addresses:** -
-  - **Components:**  `KModal`
-  - **Breaking:** yes
-  - **Impacts a11y:** no
-  - **Guidance:** Rename `KModal`'s `appendToRoot` prop to `appendToOverlay`
-
-[#722]: https://github.com/learningequality/kolibri-design-system/pull/722
-
-- [#722]
-  - **Description:** Adds new prop, `appendToOverlay`, to `KTooltip`
-  - **Products impact:** New API
-  - **Addresses:** -
-  - **Components:**  `KTooltip`
-  - **Breaking:** no
-  - **Impacts a11y:** no
-  - **Guidance:** -
-
-[#722]: https://github.com/learningequality/kolibri-design-system/pull/722
-
-- [#722]
-  - **Description:** Makes the `sidebar` icon flip in RTL languages
-  - **Products impact:** Bugfix
-  - **Addresses:** -
-  - **Components:**  Icons
-  - **Breaking:** no
-  - **Impacts a11y:** yes
-  - **Guidance:** -
-
-[#722]: https://github.com/learningequality/kolibri-design-system/pull/722
-
-
-
-- [#626]
-  - **Description:** Bump slackapi/slack-github-action from 1.25.0 to 1.26.0
-  - **Products impact:** Dev Dependency upgrade
-  - **Addresses:** -
-  - **Components:** -
-  - **Breaking:** -
-  - **Impacts a11y:** -
-  - **Guidance:** -
-
-[#626]: https://github.com/learningequality/kolibri-design-system/pull/626
-
-
-
-- [#739]
-  - **Description:** Bump elliptic from 6.5.4 to 6.5.7
-  - **Products impact:** Dev Dependency upgrade
-  - **Addresses:** -
-  - **Components:** -
-  - **Breaking:** -
-  - **Impacts a11y:** -
-  - **Guidance:** -
-
-[#739]: https://github.com/learningequality/kolibri-design-system/pull/739
-
-
-
-- [#660]
-  - **Description:** Bump pug from 3.0.2 to 3.0.3
-  - **Products impact:** Dev Dependency upgrade
-  - **Addresses:** -
-  - **Components:** -
-  - **Breaking:** -
-  - **Impacts a11y:** -
-  - **Guidance:** -
-
-[#660]: https://github.com/learningequality/kolibri-design-system/pull/660
-
-
-- [547]
-  - **Description:** Automates changelog update process in the pull requests by adding two GitHub actions: (1) to check for the presence of changelog items(s) in the pull request description, (2) to paste the item(s) to CHANGELOG.md after the PR merged.
-  - **Products impact:** none
-  - **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/533
-  - **Components:** -
-  - **Breaking:** -
-  - **Impacts a11y:** -
-  - **Guidance:** -
-
-[547]: https://github.com/learningequality/kolibri-design-system/pull/547
-
-- [#753]
-  - **Description:** Bump KDS version to 5.0.0-rc3.
-  - **Products impact:** -.
-  - **Addresses:** -.
-  - **Components:** -.
-  - **Breaking:** -.
-  - **Impacts a11y:** -.
-  - **Guidance:** -.
+ [#625]
+  - **Description:**  Update`KCard` to complete vertical/horizontal layouts with no thumbnail
+  - **Products impact:**  Card updates 
+  - **Addresses:** https://github.com/learningequality/kolibri-design-system/pull/752
+  - **Components:** `KCard` 
+  - **Breaking:** N0
+  - **Impacts a11y:** No
+  - **Guidance:**
 
-[#753]: https://github.com/learningequality/kolibri-design-system/pull/753
+[#752]https://github.com/learningequality/kolibri-design-system/pull/752
 
 - [#754]
   - **Description:** Removed the border-radius on align left.

diff --git a/docs/pages/playground.vue b/docs/pages/playground.vue
@@ -73,17 +73,8 @@
         :headingLevel="2"
         layout="vertical"
         thumbnailDisplay="small"
-        :preserveFooter="true"
         title="This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title"
       >
-
-        <template #thumbnailPlaceholder>
-          <div>
-            <div style="text-align: center;">
-              <KIcon icon="readSolid" class="icon-placeholder" />
-            </div>
-          </div>
-        </template>
         <template #belowTitle>
           <span>Below title below title below title below title below title below title below title below title below title below title below title below title below title</span>
         </template>

diff --git a/lib/KCard/index.vue b/lib/KCard/index.vue
@@ -17,8 +17,11 @@
         v-if="thumbnailDisplay !== 'none'"
         class="thumbnail"
       >
+        <!-- 
+          Render KImg even if thumbnailSrc is not provided since in that case
+          KImg takes care of showing the gray placeholder area.
+        -->
         <KImg
-          v-if="thumbnailSrc"
           :src="thumbnailSrc"
           :scaleType="thumbnailScaleType"
           :aspectRatio="thumbnailAspectRatio"