isDecorative removed.

Signed-off-by: shivangrawat30 <[email protected]>
learningequality · Oct 11, 2023 · b5774e0 · b5774e0
1 parent ff15d1a
commit b5774e0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 20 deletions.
diff --git a/docs/pages/KLogo.vue b/docs/pages/KLogo.vue
@@ -33,22 +33,20 @@
       </div>
 
       <div class="img-example-2">
-        <DocsLibraryLink component="KLogo" /> requires alternative text that describes the image unless
-        <code>isDecorative</code> is <code>true</code>. In that case, any alt text provided will be overwritten to an
-        empty string.
+        <DocsLibraryLink component="KLogo" /> requires alternative text that describes the image, or it will throw an error.
         <div>
           <div>
             <DocsShow>
               <KLogo
-                isDecorative
+                altText="kolibriLogo"
                 :height="50"
                 :width="50"
               />
             </DocsShow>
           </div>
           <DocsShowCode language="html">
             <KLogo
-              isDecorative
+              altText="kolibriLogo"
               :height="50"
               :width="50"
             />

diff --git a/lib/KLogo/index.vue b/lib/KLogo/index.vue
@@ -1,18 +1,18 @@
 <template>
 
   <div>
-    <img
+    <KImg
       :src="logo"
-      :alt="alternateText"
+      :altText="alternateText"
       :style="styleObject"
-    >
-    <slot></slot>
+    />
   </div>
 
 </template>
 
 <script>
 
+  import KImg from '../KImg.vue';
   import kolibriLogo from './kolibri-logo.svg';
 
   export default {
@@ -25,13 +25,6 @@
         type: String,
         default: '',
       },
-      /**
-       * Sets the image as decorative. This sets the alt image property to an empty string.
-       */
-      isDecorative: {
-        type: Boolean,
-        default: false,
-      },
       /**
        * Sets the height for the component
        */
@@ -89,7 +82,7 @@
     },
     computed: {
       alternateText() {
-        return this.isDecorative ? '' : this.altText;
+        return this.altText;
       },
       imgHeight() {
         return this.validateAndFormatUnits(this.height);
@@ -114,8 +107,9 @@
       },
     },
     created() {
-      if (!this.isDecorative && !this.altText) {
-        throw new Error('Missing required prop - provide altText or indicate isDecorative');
+      console.log(this.altText);
+      if (!this.altText) {
+        throw new Error('Missing required prop - provide altText');
       }
     },
     methods: {
@@ -141,7 +135,6 @@
               'vh',
               'vw',
             ];
-
             // if made up of valid numbers and valid units
             if (!isNaN(arr[0]) && validUnits.includes(arr[1])) {
               return propValue;