Skip to content

Commit

Permalink
update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
AllanOXDi committed Sep 3, 2024
1 parent b89f714 commit 534ed4b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 10 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ Changelog is rather internal in nature. See release notes for the public overvie

## Upcoming version 5.x.x (`develop` branch)

[#625]
- **Description:** Update`KCard` to complete vertical/horizontal layouts with no thumbnail
- **Products impact:** Card updates
- **Addresses:** https://github.com/learningequality/kolibri-design-system/pull/752
- **Components:** `KCard`
- **Breaking:** N0
- **Impacts a11y:** No
- **Guidance:**

[#752]https://github.com/learningequality/kolibri-design-system/pull/752

- [#754]
- **Description:** Removed the border-radius on align left.
- **Products impact:** bugfix.
Expand Down
9 changes: 0 additions & 9 deletions docs/pages/playground.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,8 @@
:headingLevel="2"
layout="vertical"
thumbnailDisplay="small"
:preserveFooter="true"
title="This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title This is a sample resource title"
>

<template #thumbnailPlaceholder>
<div>
<div style="text-align: center;">
<KIcon icon="readSolid" class="icon-placeholder" />
</div>
</div>
</template>
<template #belowTitle>
<span>Below title below title below title below title below title below title below title below title below title below title below title below title below title</span>
</template>
Expand Down
5 changes: 4 additions & 1 deletion lib/KCard/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@
v-if="thumbnailDisplay !== 'none'"
class="thumbnail"
>
<!--
Render KImg even if thumbnailSrc is not provided since in that case
KImg takes care of showing the gray placeholder area.
-->
<KImg
v-if="thumbnailSrc"
:src="thumbnailSrc"
:scaleType="thumbnailScaleType"
:aspectRatio="thumbnailAspectRatio"
Expand Down

0 comments on commit 534ed4b

Please sign in to comment.