Skip to content

Commit

Permalink
Merge pull request #338 from marcellamaki/update-toolbar-layout
Browse files Browse the repository at this point in the history
Allow for new 'nav' slot inline in the toolbar
  • Loading branch information
marcellamaki authored Jun 22, 2022
2 parents fa8fb84 + 405c259 commit 41db26f
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 10 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Releases are recorded as git tags in the [Github releases](https://github.com/learningequality/kolibri-design-system/releases) page.

## Version 1.4.x
- [#185] - Handle arrow key navigation and improve focusOutline
- [#338] - Allow for new 'nav' slot inline in the toolbar


## Version 1.3.1

- [#309] - Add jest testing environment to KDS
Expand Down
26 changes: 16 additions & 10 deletions lib/keen/UiToolbar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@
</div>
</slot>
</div>
</div>

<div class="ui-toolbar__body" :class="{ 'has-brand-divider': hasBrandDivider }">
<slot>
<div v-if="title" class="ui-toolbar__title">
{{ title }}
</div>
</slot>
<slot name="navigation" class="ui-toolbar__nav"></slot>
</div>



<div class="ui-toolbar__right">
<slot name="actions"></slot>
</div>
Expand Down Expand Up @@ -134,9 +134,12 @@
.ui-toolbar {
position: relative;
display: flex;
align-content: center;
align-items: center;
justify-content: space-between;
height: $ui-toolbar-height;
padding-left: rem(16px);
max-width: 100%;
font-family: inherit;
font-size: $ui-toolbar-font-size;
Expand All @@ -155,16 +158,22 @@
}
.ui-toolbar__left {
display: flex;
flex-shrink: 0;
align-items: center;
display: inline-flex;
}
.ui-toolbar__nav-icon {
margin-right: rem(8px);
margin-left: rem(-16px);
}
.ui-toolbar__nav {
margin-right: rem(8px);
margin-left: rem(-16px);
display: flex;
align-items: bottom;
margin-left: 16px;
}
.ui-toolbar__brand {
min-width: rem(160px);
}
Expand All @@ -175,8 +184,6 @@
}
.ui-toolbar__body {
display: flex;
flex-grow: 1;
&.has-brand-divider {
padding-left: rem(24px);
Expand All @@ -186,8 +193,7 @@
}
.ui-toolbar__right {
flex-shrink: 0;
margin-left: auto;
display: inline-block;
}
.ui-toolbar__progress {
Expand Down

0 comments on commit 41db26f

Please sign in to comment.