Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we use options.ini configuration for port selection. #128

Merged
merged 2 commits into from
May 1, 2024
Merged

Ensure we use options.ini configuration for port selection. #128

merged 2 commits into from
May 1, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 1, 2024

Fixes #112

@rtibbles rtibbles force-pushed the pass_the_port_to_the_left branch from c6894f2 to f23255a Compare May 1, 2024 14:34
@rtibbles rtibbles force-pushed the pass_the_port_to_the_left branch from f23255a to e4a1e74 Compare May 1, 2024 16:48
marcellamaki
marcellamaki approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and manual testing confirms that it works as expected on 8080 (and also as expected - not working - on another unused random port)

@marcellamaki marcellamaki merged commit aaa762c into main May 1, 2024
5 checks passed
@rtibbles rtibbles deleted the pass_the_port_to_the_left branch May 1, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App ignores options.ini port settings
2 participants
@rtibbles @marcellamaki