Add missing field description and expand Version length #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 3, 2019
|
@jamalex do you have any comments or ideas about the addition of the |
|
I'm going to make a call and say that this is necessary for the sake that we have a field in the model that's not in the database and that's bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Had issues registering version numbers that were longer than 10 characters.
During migration, I found that a field in a model wasn't created.
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
This does not need release notes, it's mostly related to testing.
Issues addressed
None.