Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always raise an error when importing from django.contrib.gis #5592

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

benjaoming
Copy link
Contributor

Summary

This is an attempt to address the issue in iiab/iiab#1382

There are version strings of libgeos system libraries that seem to make the loading crash.

TODO

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

Let's assume that our tests would break, since this is about load-time issues.. not request/response related.

Issues addressed

iiab/iiab#1382

@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #5592 into 0.17.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5592   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         113      113           
  Lines        6508     6508           
=======================================
  Hits         4299     4299           
  Misses       2209     2209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a3462...768629a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #5592 into 0.17.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5592   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         113      113           
  Lines        6508     6508           
=======================================
  Hits         4299     4299           
  Misses       2209     2209
Impacted Files Coverage Δ
kalite/distributed/views.py 78.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a3462...56bee65. Read the comment docs.

@benjaoming
Copy link
Contributor Author

Ay, just ran into this on a normal 18.04

@benjaoming benjaoming merged commit 703b862 into learningequality:0.17.x Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant