Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPi fix: Make running retrievecontentpack download NOT update the DB #5578

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jul 8, 2018

Summary

Before, we called update_stage, which would write progress to the DB. A pretty bad idea.

On RPi, it basically meant it was impossible to run retrievecontentpack in some cases.

Thanks @holta for reporting this!

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

I know this isn't necessarily nicely done or follows through with any kind of consequence for other commands, but this fixes the immediate issue for RPi.

Issues addressed

#5575
#4892

@benjaoming benjaoming added this to the 0.17.5 milestone Jul 8, 2018
@benjaoming benjaoming merged commit b445d21 into learningequality:0.17.x Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant