RPi fix: Make running retrievecontentpack download NOT update the DB #5578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before, we called
update_stage
, which would write progress to the DB. A pretty bad idea.On RPi, it basically meant it was impossible to run
retrievecontentpack
in some cases.Thanks @holta for reporting this!
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
I know this isn't necessarily nicely done or follows through with any kind of consequence for other commands, but this fixes the immediate issue for RPi.
Issues addressed
#5575
#4892