Fix database move message #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
commented
Aug 19, 2017
| @@ -398,7 +395,7 @@ def handle(self, *args, **options): | |||
| ######################## | |||
|
|
|||
| # Move database file (if exists) | |||
| if install_clean and database_file and os.path.exists(database_file): | |||
| if install_clean and database_file and database_exists: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5506 +/- ##
==========================================
- Coverage 62.77% 62.76% -0.02%
==========================================
Files 117 117
Lines 6555 6553 -2
==========================================
- Hits 4115 4113 -2
Misses 2440 2440
Continue to review full report at Codecov.
|
Simplify some of the reasoning around whether a database exists at a clean install
benjaoming
force-pushed
the
fix-database-move-message
branch
from
6eb3ddb to
cc760cf
Compare
|
@mrpau-eugene could you check if I got it right? It's a bit complicated, would be nice with another pair of eyes to verify :) |
mrpau-eugene
approved these changes
Nov 15, 2017
benjaoming
commented
Nov 17, 2017
| if not options["interactive"] \ | ||
| or raw_input_yn("Keep database file and upgrade to KA Lite version %s? " % VERSION) \ | ||
| or not raw_input_yn("Remove database file '%s' now? " % database_file) \ | ||
| or not raw_input_yn("WARNING: all data will be lost! Are you sure? "): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
benjaoming
commented
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current setup command wrongly claims that a database file exists and will be backed up on a clean release: