Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line breaks in buttons so text isn't cut #5448

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

benjaoming
Copy link
Contributor

Summary

Simple fix. Hopefully it doesn't break other aspects of our buttons, but manual tests of the next prerelease will have to verify this @radinamatic

Otherwise, this is easy to revert.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

None, will be thoroughly tested in the prerelease

Issues addressed

#5004

@benjaoming benjaoming added this to the 0.17.1 milestone Apr 14, 2017
@benjaoming benjaoming self-assigned this Apr 14, 2017
@benjaoming
Copy link
Contributor Author

Wrap looks like this:

screenshot from 2017-04-14 23-39-30

@codecov
Copy link

codecov bot commented Apr 14, 2017

Codecov Report

Merging #5448 into 0.17.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5448      +/-   ##
==========================================
- Coverage   61.39%   61.37%   -0.02%     
==========================================
  Files         118      118              
  Lines        6574     6574              
==========================================
- Hits         4036     4035       -1     
- Misses       2538     2539       +1
Impacted Files Coverage Δ
kalite/cli.py 42.35% <ø> (ø) ⬆️
kalite/coachreports/models.py 84.95% <0%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0786c8c...5b61330. Read the comment docs.

@benjaoming benjaoming merged commit 8bce7a7 into learningequality:0.17.x Apr 14, 2017
@benjaoming benjaoming removed the has PR label Apr 14, 2017
@benjaoming benjaoming deleted the fix-button-wrap branch April 22, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant