Remove legacy code, PROJECT_PATH and related test case code_tests #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2017 11:12
…setup' management command
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5429 +/- ##
==========================================
+ Coverage 51.76% 51.77% +<.01%
==========================================
Files 143 143
Lines 7499 7496 -3
==========================================
- Hits 3882 3881 -1
+ Misses 3617 3615 -2
Continue to review full report at Codecov.
|
added 2 commits
April 4, 2017 12:31
…ontain any test_* methods, thus nothing ever gets called)
benjaoming
changed the title
benjaoming
commented
Apr 5, 2017
| else: | ||
| start_script_path = os.path.realpath( | ||
| os.path.join(settings.PROJECT_PATH, "..", "bin", "windows", "kalite.bat")) | ||
| else: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes broken code in 'setup' management command
Targeting for 0.17.1 because there are no current plans for 0.18, and this is just a legacy cleanup.
TODO
Reviewer guidance
As noted in the release notes,
PROJECT_PATHwas not even configurable. It was used wrongly, too. Its default value was theKALITE_HOMEenvironment, but some places of usage assumed it would be a "project root", which is a remnant of when KA Lite was distributed as a static directory.Issues addressed
#4104