prevent underneath body element from scrolling when scroll the sideba… #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r or sidebar-fade area
|
A separate issue, seems clicking on sidebar item not working on IE9. @benjaoming is kalite 0.17 supposed to support IE9? |
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5410 +/- ##
=======================================
Coverage 51.76% 51.76%
=======================================
Files 143 143
Lines 7499 7499
=======================================
Hits 3882 3882
Misses 3617 3617Continue to review full report at Codecov.
|
|
It sounds like from @nedrichards that it's been tested for Edge, so I've marked it as Done. Merging now, this will be part of the 0.17.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r or sidebar-fade area
Summary
Fix the issue #5407
Only tested on Mac chrome and android chrome browsers, would need more testing on different devices, especially on Linux where the issue is originally discovered.
TODO