Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize release notes for 0.17 - still needs proofreading #5398

Merged
merged 2 commits into from
Jan 27, 2017

Conversation

benjaoming
Copy link
Contributor

Summary

Finalizing release notes, should be the last step before 0.17.x is ready for release :)

@benjaoming benjaoming added this to the 0.17.0 milestone Jan 27, 2017
@benjaoming benjaoming self-assigned this Jan 27, 2017
@@ -29,7 +32,7 @@ inaccuracies in 0.16 content packs are solved.

.. note::
After upgrading to version 0.17, you should visit the *Manage* tab to
upgrade your language and videos. You can also use
upgrade your languages and videos. You can also use
``kalite manage contentpackchecker all --update`` to automate the download and
installation of new content packs.

This comment was marked as spam.

@codecov-io
Copy link

codecov-io commented Jan 27, 2017

Current coverage is 51.82% (diff: 100%)

Merging #5398 into 0.17.x will not change coverage

@@             0.17.x      #5398   diff @@
==========================================
  Files           143        143          
  Lines          7491       7491          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3882       3882          
  Misses         3609       3609          
  Partials          0          0          

Powered by Codecov. Last update 1b68250...db20f5c

@radinamatic
Copy link
Member

GH is not letting me comment on text that is not part of the latest commit, so here are a couple of suggestions:

(Line numbers first)

  • 50: deeplink - I'd separate this into deep link(Wikipedia).
  • 62: change fixing into which fixed.
  • 90: change in other way into in some other way
  • 94: change mis-aligned into misaligned
  • 114: change has been removed into have been removed
    It is all located as would sound better to me as Everything is labeled as, but I may be misunderstanding something...
  • 115: Change the The parts of ``kalite.testing`` application that were related to benchmarks. These commands have been unmaintained and are outdated. into The parts of ``kalite.testing`` application related to benchmarks have been unmaintained and are outdated.
  • 121: change convetions into conventions.
  • 122: change PyRun is no longer supported, code that pertained its lacking ``multiprocessing`` has been removed. into PyRun is no longer supported and has been removed (it was lacking ``multiprocessing``) .

@benjaoming
Copy link
Contributor Author

62: change fixing into which fixed.

I kept this, thinking it's a way I've been writing English for a long time. Fixing it consequently would mean investing much effort :D

@benjaoming benjaoming merged commit 27f2d97 into learningequality:0.17.x Jan 27, 2017
@benjaoming benjaoming removed the has PR label Jan 27, 2017
@benjaoming benjaoming deleted the releasenotes-017 branch February 9, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants