Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special little hotfix for signup page redirect - fixes #3926 #5315

Merged

Conversation

benjaoming
Copy link
Contributor

Summary

Forces a javascript redirect if the word "signup" appears in the URL. The page itself is already protected server-side and users can't actually signup after logging in.

@codecov-io
Copy link

codecov-io commented Oct 3, 2016

Current coverage is 51.13% (diff: 100%)

Merging #5315 into develop will decrease coverage by 0.01%

@@            develop      #5315   diff @@
==========================================
  Files           141        141          
  Lines          7468       7468          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           3820       3819     -1   
- Misses         3648       3649     +1   
  Partials          0          0          

Powered by Codecov. Last update 33497ae...601bdbc

@benjaoming benjaoming merged commit 05c6e5c into learningequality:develop Oct 3, 2016
@benjaoming benjaoming removed the has PR label Oct 3, 2016
@benjaoming benjaoming deleted the redirect-signup-login branch October 6, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants