Remove watchify code from cli, it belongs in runserver (which works!) #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
force-pushed
the
remove-watchify-from-cli
branch
from
df484fd to
8cc9380
Compare
Current coverage is 51.26% (diff: 50.00%)@@ develop #5314 diff @@
==========================================
Files 141 141
Lines 7468 7447 -21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 3820 3818 -2
+ Misses 3648 3629 -19
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the release notes will read, we have
bin/kalite manage runserver --settings=kalite.project.settings.devwhich does the job.But furthermore, we should not expose developer options to users.