Pinned node module dependencies in package.json to specific versions. #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids versions from shifting beneath our feet even when there are no code changes, causing unexpected issues (such as a problem with coach reports caused by background updating of bootstrap-datepicker).
Merged
|
Outrageous! Changing so many dependencies this close to release! |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our node module dependencies were specified with "floating" version numbers (starting with
~or^), meaning they would be automatically upgraded to newer version even without our codebase changing. In theory, this could cause problems, and in practice, we saw the first of these problems arise withbootstrap-datepickernot behaving properly on the coach report pages due to a background version change.This PR pins all modules to their latest versions as of today. These are the versions we've been building and testing with, and hence are the safest versions to pin.