Open docs link in a separate window (accessible) #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is flaky. The fix is good, so merging. |
MCGallaspy
added a commit
that referenced
this pull request
Mar 17, 2016
Open docs link in a separate window (accessible)
|
No idea where the test came from, wasn't me - scout's honor! |
|
Yeah, by flaky test I mean something which fails randomly. Has nothing to do with your changes in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4977.
Tab link now has both a title & target attribute with the appropriate icon and accessible info for the screenreader users. I renamed it to
DOCSsinceUSER MANUALseemed too big for me visually, although I have consideredHELPtoo...@MCGallaspy
Screenshots