I18n fixes #4972
Merged
I18n fixes #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used by the create_dummy_language_pack command.
aronasorman
force-pushed
the
i18n-fixes
branch
3 times, most recently
from
efedc3b to
c796d64
Compare
|
Tests are now passing. |
| Extract the strings from the inline help narratives yml files. Returns an | ||
| iterator containing the po file entries. Optional inline_help_parameter | ||
| specifies where the inline help narratives path is. Else, it defaults | ||
| to settings.CONTENT_DATA_PATH + "narratives.yml" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looking good, great commit history! Just one comment above on a docstring/unused parameter. |
|
Addressed comment. Tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some i18n fixes to get ready for the 0.16 po file release.
Reviewer guidance
Review by commit. Changes will make more sense.