Sidebar bug fix and test fix up #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle entry point.
Small tweak to content rec test.
| # checking if the request returned any of the exercises | ||
| self.assertEqual(len(exercises),1) | ||
| assert len(exercises) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Tested. Confirmed sidebar fix. Just one optional nitpick. Address it or not, then merge at will @rtibbles. |
rtibbles
added a commit
that referenced
this pull request
Mar 4, 2016
Sidebar bug fix and test fix up
This was referenced Mar 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a sidebar rendering bug, and also extant test failures on 0.16.x
Issues addressed
Fixes #4948 (follow steps for replication there to verify fix).
Fixes #4956 (passing test suite will verify this fix).
Screenshots (if appropriate)
Sidebar works as intended:
