Remove that custom pt-BR -> pt mapping. #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tada:
|
| @@ -108,9 +108,6 @@ def wrapper(*args, **kwargs): | |||
| # TODO(jamalex): BURN IT ALL DOWN! | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pt-BR works fine without it. In fact, having this mapping now prevents the content db from being annotated properly.
|
Spot begone! |
|
💥 |
|
Merging this now, so we can build an sdist for the Google Brazil folks! |
aronasorman
added a commit
that referenced
this pull request
Mar 1, 2016
Remove that custom pt-BR -> pt mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For 0.15 we made a hack that manually maps
pt-BRtopt. This hack is not needed anymore, in fact it actively hinderspt-BRfrom working properly by causing annotation to happen on a nonexistent DB.