Allow positional arguments with dashes inside #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It choked on valid commands like: `kalite manage retrievecontentpack local es-ES foo.zip` Because of the dash in the middle of a positional argument. So only match if there is preceding whitespace. Also remove redundant non-capturing group -- negative lookaheads don't capture anyway.
MCGallaspy
changed the title
|
Can confirm that this command now works as expected: |
|
Will wait 'til the test is fixed, or otherwise merged by someone else. |
rtibbles
added a commit
that referenced
this pull request
Mar 1, 2016
Allow positional arguments with dashes inside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4935:
Remove reference to nonexistent CHANGELOG.rst in our PR template, too.
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)