Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catches for missing data or None returns in content data. #4923

Merged
merged 7 commits into from
Feb 29, 2016

Conversation

rtibbles
Copy link
Member

Summary

Short description

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)

Reviewer guidance

Main oddity is that one of the files had tab indents, so that has been rectified.

Issues addressed

Fixes #4910

@rtibbles rtibbles added this to the 0.16.0 milestone Feb 26, 2016
@rtibbles
Copy link
Member Author

@aronasorman This is now ready to merge, and fixes a bug which is responsible for many flaky Behave test failures on 0.16.x - so would be good to get in sooner rather than later for everyone's sake!

aronasorman added a commit that referenced this pull request Feb 29, 2016
Add catches for missing data or None returns in content data.
@aronasorman aronasorman merged commit c0fbeb0 into learningequality:0.16.x Feb 29, 2016
@aronasorman aronasorman deleted the robustify_content_rec branch February 29, 2016 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants