Add playback speed button to video player #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed inline video.js configuration options in favor of explicit configuration in our view.
| @@ -1,5 +1,5 @@ | |||
| <div id="video-player"{{#unless content_urls }} class="client-online-only"{{/unless}}> | |||
| <video class="video-player video-js vjs-default-skin vjs-fullscreen" id="{{ random_id }}" controls preload="auto" width="auto" height="auto" {{#if content_urls.thumbnail }}poster="{{ content_urls.thumbnail }}" {{/if}}data-setup="{}"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks great, perhaps consider adding 1.25 speed, but signoff to merge at will. |
|
Okay, I'll add the 1.25 speed. But just to be clear you are the one supposed to merge this (or not merge it), in general I try to avoid merging my own changes. |
|
Sure thing, merging. |
jamalex
added a commit
that referenced
this pull request
Feb 26, 2016
…ed-setting Add playback speed button to video player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the playback speed button back to our video player. Removed inline video.js configuration options in favor of explicit configuration in our view. @jamalex you're identified as my bug-buddy for videos, but if you don't have the opportunity to review this then please indicate that's the case.
TODO
Have tests been written for the new code?No. There's no good way to test KA Lite's javascript.Issues addressed
Fixes #4639.