Let commands actually set their progress log.

[rtibbles]

Summary

Removes the seemingly superfluous foreground flag on UpdatesCommands - as it is set during init, can't be modified post hoc after handle (as suggested in the comment that implemented it).

Reviewer guidance

This is a reversion of a previous change that caused this bug.

Issues addressed

Fixes #4817.

@benjaoming please comment as to why the foreground flag is necessary if I am removing it in this way (and just letting the process_log be None), and I will try to update this to account for that use case, but for now, it just seemed to block the intended use of these UpdatesCommands.

[benjaoming]

@rtibbles Creating the content db template happens from command line, so it's supposed to run in the foreground and not put data in data.sqlite (which isn't even created at that point).

I introduced the --foreground flag especially for make assets, which invokes:

bin/kalite manage retrievecontentpack download en --minimal --foreground --template

I'm not sure why it has affect other things, apologies for that. But please don't remove it, consider this commit:

rtibbles@1b53758#diff-9b6a9dbe0240241084068eb7080204e8

[rtibbles]

OK, will work to make it function as intended - however, from what I can tell, the foreground flag is actually doing nothing, because the options never get parsed anywhere?

So, in the retrievecontentpacks instance, you actually want it not to be foreground, because you want it to run without creating process logs, right? In which case, we should maybe have a 'background' flag that gets invoked instead, and prevents the process logs from being accessed?

[rtibbles]

How about this, @benjaoming? Setting the foreground flag should now prevent it from doing any process_log related malarkey, and each Class now has to call the setup method in handle to make sure the process logs are there if needed.

[benjaoming]

Apparently a blunder in that I set self.foreground to False disregarding my own setup argument, good intention half delivery :) Thanks for fixing it!