Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finally remove batch scripts; moved to installers repo #4771

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Finally remove batch scripts; moved to installers repo #4771

merged 1 commit into from
Feb 1, 2016

Conversation

MCGallaspy
Copy link
Contributor

@MCGallaspy MCGallaspy added this to the 0.16.0 milestone Dec 19, 2015
@MCGallaspy MCGallaspy changed the title Finally remove; moved to installers repo Finally remove batch scripts; moved to installers repo Jan 5, 2016
@benjaoming
Copy link
Contributor

Wow, KA Lite, you're growing up to be a real swan :D

benjaoming added a commit that referenced this pull request Feb 1, 2016
@benjaoming
Merge pull request #4771 from MCGallaspy/remove-scripts-finally
d43ec73 
Finally remove batch scripts; moved to installers repo
@benjaoming benjaoming merged commit d43ec73 into learningequality:0.16.x Feb 1, 2016
@benjaoming benjaoming removed the has PR label Feb 1, 2016
@benjaoming benjaoming mentioned this pull request Feb 1, 2016
Merged
@benjaoming
Copy link
Contributor

Oops oops oops, did honestly not think this code would come with a test!


======================================================================
FAIL: test_scripts_path (kalite.basetests.tests.PathsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/ka-lite/kalite/basetests/tests.py", line 328, in test_scripts_path
    self.check_path(scripts_path, os.X_OK, msg=msg)
  File "/home/ubuntu/ka-lite/kalite/basetests/tests.py", line 99, in check_path
    self.fail(msg)
AssertionError: 1 access to /home/ubuntu/ka-lite/scripts path failed: 

----------------------------------------------------------------------
Ran 206 tests in 329.204s

@benjaoming
Copy link
Contributor

Could you make another PR with the weird test removed?

@MCGallaspy
Copy link
Contributor Author

Yes, will do.

MCGallaspy added a commit to MCGallaspy/ka-lite that referenced this pull request Feb 2, 2016
@MCGallaspy
Remove irrelevant test
e774d77 
The "scripts path" it was testing was removed from the
KA Lite repo in learningequality#4771.
@MCGallaspy MCGallaspy mentioned this pull request Feb 2, 2016
Merged
@benjaoming
Copy link
Contributor

Thanks, I shall revert my revert after merging the test :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MCGallaspy @benjaoming