Fix language pack availability issue in 0.14.1 #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um, I just had a total brain-fart with that commit message. Incoming amendment. |
The central server sends a short version (e.g. 0.14), which the distributed server then compares to its long version (e.g. 0.14.1). The problem is that 0.14 compares as less than 0.14.1, so language packs are shown as unavailable. Instead, when comparing two mismatched-length versions, only consider the shortest version available -- thus 0.14 and 0.14.1 would compare equal. Then the languagepack versions will be compared, which is the actual intent.
MCGallaspy
force-pushed
the
lang-pack-js-fix
branch
from
68812e1 to
290b4fc
Compare
|
Testing. |
|
Works. |
aronasorman
added a commit
that referenced
this pull request
Oct 7, 2015
Fix language pack availability issue in 0.14.1
|
Just wanna clue in @EdDixon because this is the issue that caused the blue button to be gone. Now it's back in 0.14.2 which the above PR tracks.
|
This was referenced Oct 8, 2015
|
Need to cherry-pick to 0.15 and develop as well. |
|
Is in 0.15. Should get merged to develop from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language packs not shown as available, due to version comparison on distributed server. See my commit message/code.
See @aronasorman's note for context: fle-internal/ka-lite-central@7a48ceca9eff#diff-b4c6913ca485fa33b3dfb6040efc3dddR680
We should cherry-pick this to
0.15.xanddevelopas well.Commit message:
@jamalex or @rtibbles any caveats here I should be aware of?
Due immediately.