Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #4430 #4480

Merged
merged 2 commits into from
Sep 24, 2015
Merged

fix for #4430 #4480

merged 2 commits into from
Sep 24, 2015

Conversation

66eli77
Copy link
Contributor

@66eli77 66eli77 commented Sep 24, 2015

No description provided.

@djallado
Copy link
Contributor

@66eli77, I tested your fix and I observed that the progress bar is now showing but it looks shorter and the Cancel Video Downloads button is misaligned.

screen shot 2015-09-24 at 7 00 08 pm

@EdDixon
Copy link
Contributor

EdDixon commented Sep 24, 2015

@66eli77 @djallado I am testing now and can confirm what @djallado observations above except that the button alignment looks ok in the latest develop installer?

@EdDixon
Copy link
Contributor

EdDixon commented Sep 24, 2015

After a server restart I did encounter the issue with the misaligned button.
2015-09-24_11-43-42

@rtibbles
Copy link
Member

This change is extant on 0.15.x, so not a blocker to merging this PR.

@rtibbles
Copy link
Member

Opened a separate issue for the progress bar and cancel button: #4486

rtibbles added a commit that referenced this pull request Sep 24, 2015
@rtibbles rtibbles merged commit a3bf8db into learningequality:0.15.x Sep 24, 2015
@rtibbles rtibbles removed the has PR label Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants