Properly triggers login on API 403. #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| window.userView.login_start_open = true; | ||
| }); | ||
| window.toggleNavbarView.userView.login_start_open = true; | ||
| window.statusModel.fetch(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@66eli77 This should fix the issue! |
|
cool, verified, merging |
66eli77
added a commit
that referenced
this pull request
Sep 23, 2015
Properly triggers login on API 403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4449
Currently, if you are logged out and an API request returns a 403 forbidden, then our modal login does not get triggered (it will produce a Javascript error instead).
To test this, go to developer console, resources, and delete the sessionId cookie while on the video download page.