-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New diagnose command diagnoses system (not so robust) #4136
Conversation
Marking this a release blocker because I want the ka-lite-gtk UI to depend on it, hope that's okay. |
On a further note: Since 0.15 should move kalitectl, I would like to keep the function here for now. Later, if needed, we could create a utility function that outputs raw data for other views, like a web page, to utilize. |
This won't be so meaningful, since we limit the number of locally stored syncsessions to 10. Perhaps "LAST SYNCED" and "LAST SYNC RESULTS" (success, failed, etc). Perhaps it could list "RECORDS IN PURGATORY" or something, too.
Looks like it's using the name (which in some cases could be ambiguous); Zone ID would be better ( |
@@ -592,6 +605,85 @@ def status(): | |||
} | |||
|
|||
|
|||
def diagnose(): | |||
""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
A couple notes, then looks good to merge as a first pass. Thanks! |
In that case, we should remove it here?
|
|
Most of those are just checking whether it was synced at all, which is still useful. The "# Times Synced" column isn't so useful, but let's leave it for now -- we need to rethink those pages in general at some point, as the UX is bad. |
Are these absolute/relative paths? Why no leading |
Beauty! Looks good to merge, if it's been testing in |
No, but I think it might be relevant to look at it in relation to calls from another user, something like
|
Yes, that works, too!
|
Merging this because it's harmless and we can do improvements in new issues. |
New diagnose command diagnoses system (not so robust)
Example: