-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn users on debian if they are running with a non-default user #4051
warn users on debian if they are running with a non-default user #4051
Conversation
This one looks pretty critical. Can you add milestones to your PRs when you open them? |
Sorry, that was a miss. Is definitely intended for 0.14. It was also included in alpha7. |
Going to make an amendment after a change of /etc/ka-lite layout.... |
So this is ready to be merged, any critical views? |
I think this might interact with some of the stuff @rtibbles was working on, so perhaps he could take a look here as well? |
So I think this one is definitely a prerequisite for our default debconf flow, @jamalex could you have the final check and merge it? I've tested this already in alpha7 and find that it's "low-risk". |
@@ -78,6 +85,28 @@ if not os.path.exists(kalite_path): | |||
# Converts to normal string for Windows users, where it gets turned into a unicode string and errors out in subprocess | |||
env['KALITE_DIR'] = str(kalite_path) | |||
|
|||
# TODO(benjaoming): Delegate responsibility to the .deb package | |||
if os.path.isfile("/etc/ka-lite/username"): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
… one before checking dir contents
This has been part of 5 alpha releases now. Fixed @MCGallaspy 's comments. Merging now. |
warn users on debian if they are running with a non-default user
Example:
Pressing enter exits, entering y/Y continues. Having something in .kalite makes it skip.