Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn users on debian if they are running with a non-default user #4051

Merged
merged 5 commits into from
Jul 27, 2015

Conversation

benjaoming
Copy link
Contributor

Example:

✗ bin/kalite asdasd
You are not running kalite as the default user ka-lite. This is recommended unless you want to re-create the database and start storing new videos/exercises etc. for a different user account

To run the command as the default user, run this instead:

    sudo su ka-lite -s /bin/sh -c bin/kalite asdasd

Do you wish to continue? [y/N] 

Pressing enter exits, entering y/Y continues. Having something in .kalite makes it skip.

@MCGallaspy
Copy link
Contributor

This one looks pretty critical. Can you add milestones to your PRs when you open them?

@benjaoming benjaoming added this to the 0.14.0 milestone Jul 13, 2015
@benjaoming
Copy link
Contributor Author

Sorry, that was a miss. Is definitely intended for 0.14. It was also included in alpha7.

@benjaoming
Copy link
Contributor Author

Going to make an amendment after a change of /etc/ka-lite layout....

@benjaoming
Copy link
Contributor Author

So this is ready to be merged, any critical views?

@jamalex
Copy link
Member

jamalex commented Jul 13, 2015

I think this might interact with some of the stuff @rtibbles was working on, so perhaps he could take a look here as well?

@benjaoming
Copy link
Contributor Author

So I think this one is definitely a prerequisite for our default debconf flow, @jamalex could you have the final check and merge it? I've tested this already in alpha7 and find that it's "low-risk".

@benjaoming benjaoming mentioned this pull request Jul 15, 2015
8 tasks
@@ -78,6 +85,28 @@ if not os.path.exists(kalite_path):
# Converts to normal string for Windows users, where it gets turned into a unicode string and errors out in subprocess
env['KALITE_DIR'] = str(kalite_path)

# TODO(benjaoming): Delegate responsibility to the .deb package
if os.path.isfile("/etc/ka-lite/username"):

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This was referenced Jul 17, 2015
@benjaoming
Copy link
Contributor Author

This has been part of 5 alpha releases now. Fixed @MCGallaspy 's comments.

Merging now.

benjaoming added a commit that referenced this pull request Jul 27, 2015
warn users on debian if they are running with a non-default user
@benjaoming benjaoming merged commit b56391f into learningequality:0.14.x Jul 27, 2015
@benjaoming benjaoming removed the has PR label Jul 27, 2015
@benjaoming benjaoming deleted the non-default-user branch August 19, 2015 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants