Test and fix for regression error on SyncedModel.full_clean(imported=True) #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamalex
added a commit
that referenced
this pull request
Apr 12, 2015
0.13.x (plus #3514) into central-develop
|
Heh. Travis is trying to pull the wrong PR (#3515). WHY |
|
Is this the one causing the registration errors? |
|
Looks groovy, let me just try to figure out what's going on with Travis. |
|
Test runs fine locally. |
MCGallaspy
added a commit
that referenced
this pull request
Apr 15, 2015
Test and fix for regression error on SyncedModel.full_clean(imported=True)
This was the one causing the syncing errors (and was caused by the fixes for the reg errors). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started showing up on the central server tests, even though it was passing here (since we never do
full_clean(imported=True)in the distributed server tests, only in the ecosystem tests on the central server). Adding the fix here, along with a test so that any regressions will be caught here directly.